Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing local echoes and remove redundant failed sent message menu #2983

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-feature for a new feature label Jun 28, 2024
@stefanceriu stefanceriu requested a review from pixlwave June 28, 2024 11:06
@stefanceriu stefanceriu requested a review from a team as a code owner June 28, 2024 11:06
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f595702

1 similar comment
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f595702

Copy link

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (3cc4145) to head (f595702).

Files Patch % Lines
...een/View/Style/TimelineItemBubbledStylerView.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2983      +/-   ##
===========================================
+ Coverage    77.86%   77.99%   +0.13%     
===========================================
  Files          693      693              
  Lines        53792    53770      -22     
===========================================
+ Hits         41884    41940      +56     
+ Misses       11908    11830      -78     
Flag Coverage Δ
unittests 68.59% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 7e999f0 into develop Jun 28, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/sendQueueAdditions branch June 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants