Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Sentry instrumentation on top of the existing Signposter #2985

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Setup Sentry instrumentation on top of the existing Signposter #2985

merged 4 commits into from
Jun 28, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-feature for a new feature label Jun 28, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner June 28, 2024 14:27
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team June 28, 2024 14:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 64bdbca

@stefanceriu stefanceriu added pr-misc for other changes and removed pr-feature for a new feature labels Jun 28, 2024
pixlwave
pixlwave approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think my only question is should we perhaps hash the server name instead of collecting it?

ElementX/Sources/Services/BugReport/BugReportService.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Analytics/AnalyticsService.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Application/AppCoordinator.swift Outdated Show resolved Hide resolved
ElementX/Sources/Application/AppCoordinator.swift Show resolved Hide resolved
ElementX/Sources/Services/Analytics/Signposter.swift Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 3c50088 into develop Jun 28, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/sentryTweaks branch June 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave