Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit by timeline item only if the event id is missing #2989

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 1, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner July 1, 2024 13:44
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 1, 2024 13:44
Copy link

github-actions bot commented Jul 1, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against bbac069

@Velin92 Velin92 added the pr-bugfix for bug fix label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (b2c9878) to head (321ed10).

Current head 321ed10 differs from pull request most recent head bbac069

Please upload reports for the commit bbac069 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2989      +/-   ##
===========================================
- Coverage    77.89%   77.87%   -0.03%     
===========================================
  Files          694      693       -1     
  Lines        53834    53810      -24     
===========================================
- Hits         41935    41904      -31     
- Misses       11899    11906       +7     
Flag Coverage Δ
unittests 68.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@Velin92 Velin92 enabled auto-merge (squash) July 2, 2024 09:13
@Velin92 Velin92 disabled auto-merge July 2, 2024 09:14
@Velin92 Velin92 force-pushed the mauroromito/fix_edit_for_remote_only branch from 321ed10 to bbac069 Compare July 2, 2024 09:14
@Velin92 Velin92 merged commit dac363c into develop Jul 2, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_edit_for_remote_only branch July 2, 2024 09:14
Copy link

sonarqubecloud bot commented Jul 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants