Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset keyboard after message sent #299

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

ismailgulek
Copy link
Contributor

Fixes #269

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f627816

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 36.23% // Head: 36.16% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (f627816) compared to base (05986cd).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
- Coverage    36.23%   36.16%   -0.08%     
===========================================
  Files          216      216              
  Lines        14491    14520      +29     
  Branches      7483     7505      +22     
===========================================
  Hits          5251     5251              
- Misses        9112     9142      +30     
+ Partials       128      127       -1     
Flag Coverage Δ
unittests 12.16% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ens/RoomScreen/View/MessageComposerTextField.swift 54.34% <75.00%> (-14.46%) ⬇️
...rces/Services/UserSession/KeychainController.swift 64.91% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Nov 8, 2022
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@ismailgulek ismailgulek merged commit 7a7680b into develop Nov 8, 2022
@ismailgulek ismailgulek deleted the ismail/269_reset_keyboard branch November 8, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard doesn’t change back to alphabetic mode after you send a msg
2 participants