FIX: saving draft did not save the pill markdown content #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against c9da6d6 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3003 +/- ##
===========================================
+ Coverage 77.78% 77.84% +0.06%
===========================================
Files 695 695
Lines 53851 53855 +4
===========================================
+ Hits 41886 41922 +36
+ Misses 11965 11933 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jul 5, 2024
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/ComposerToolbarViewModel.swift
Outdated
Show resolved
Hide resolved
Velin92
force-pushed
the
mauromito/save_draft_mention_fix
branch
from
69de5e7 to
bfdfefb
Compare
Velin92
force-pushed
the
mauromito/save_draft_mention_fix
branch
from
bfdfefb to
84db62f
Compare
where the content of the draft saved was ignoring any pill in it.
Velin92
force-pushed
the
mauromito/save_draft_mention_fix
branch
from
84db62f to
c9da6d6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will allow the saved draft to contain the markdown content of a pill... however when restored we will still display the markdown only since the plain text composer still has no way to directly interpret and convert a markdown into a pill before its sent.