Make sure the BugReportScreen allows the user to retry if sending fails. #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
commented
Jul 8, 2024
Comment on lines
-128
to
-134
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.userID, "@mock.client.com") | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.deviceID, nil) | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.text, "") | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.includeLogs, true) | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.canContact, false) | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.githubLabels, []) | ||
| XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.files, []) |
There was a problem hiding this comment.
These didn't really seem necessary for testing what happens when sending fails as they're already checked on the success path.
Generated by 🚫 Danger Swift against 1069bd9 |
pixlwave
force-pushed
the
doug/retry-rageshakes
branch
from
17df053 to
b5891c1
Compare
pixlwave
force-pushed
the
doug/retry-rageshakes
branch
from
b5891c1 to
1069bd9
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3012 +/- ##
===========================================
- Coverage 77.78% 77.73% -0.05%
===========================================
Files 695 695
Lines 53851 53849 -2
===========================================
- Hits 41886 41858 -28
- Misses 11965 11991 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Velin92
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2974