Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle renamed PIN alert string. #3024

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Handle renamed PIN alert string. #3024

merged 1 commit into from
Jul 11, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 10, 2024

Nothing major:

  • swift run tools download-strings --all-languages
  • Fix the compile errors.

@pixlwave pixlwave added the pr-i18n for translations label Jul 10, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 10, 2024 17:17
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 10, 2024 17:17
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1eaa6ea

Copy link

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (84e7853) to head (1eaa6ea).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3024      +/-   ##
===========================================
+ Coverage    77.88%   77.91%   +0.02%     
===========================================
  Files          695      695              
  Lines        53993    53993              
===========================================
+ Hits         42055    42066      +11     
+ Misses       11938    11927      -11     
Flag Coverage Δ
unittests 68.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit c164e47 into develop Jul 11, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/localazy branch July 11, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-i18n for translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants