Upgrade the project to use Xcode 15.4 #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 14580ba |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3027 +/- ##
===========================================
+ Coverage 77.88% 77.93% +0.04%
===========================================
Files 695 695
Lines 53993 53997 +4
===========================================
+ Hits 42052 42080 +28
+ Misses 11941 11917 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Velin92
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is (as always) snapshot related:
Preview snapshots were failing whenever a
MessageTextinstance had more than 5 lines of text. Tracked it down to pointfreeco/swift-snapshot-testing#871 which turns out to be caused by the library snapshotting at an origin of(10000, 10000)whenever the safe area is set to.zero. Because of this I've tweaked the stencil to use a value of.oneand now we're using an iPhone SE to generate them as it has the smallest safe area of all the supported devices.This seems to have helped with a handful of issues we were seeing anyway such as the below:
That said I caveat it with the fact it has introduced the following rendering issue with the use of our
searchControllermodifier. However this only presents itself on an iPhone, it looks fine on iPad.