Show Encryption Authenticity warnings on messages in the timeline. #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 93c1330 |
pixlwave
reviewed
Jul 17, 2024
pixlwave
reviewed
Jul 17, 2024
ElementX/Sources/Services/Timeline/TimelineItemContent/RoomTimelineItemProperties.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItemContent/MessageShield.swift
Outdated
Show resolved
Hide resolved
BillCarsonFr
force-pushed
the
valere/e2ee_message_shields
branch
from
affbad7 to
fde64d4
Compare
|
pixlwave
force-pushed
the
valere/e2ee_message_shields
branch
2 times, most recently
from
314a763 to
aefe0bb
Compare
pixlwave
force-pushed
the
valere/e2ee_message_shields
branch
from
aefe0bb to
b8306fd
Compare
pixlwave
changed the title
pixlwave
added
pr-wip
pixlwave
force-pushed
the
valere/e2ee_message_shields
branch
from
b8306fd to
60918a1
Compare
pixlwave
reviewed
Aug 5, 2024
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineItemSendInfoLabel.swift
Show resolved
Hide resolved
pixlwave
force-pushed
the
valere/e2ee_message_shields
branch
from
60918a1 to
9d67e4f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3051 +/- ##
===========================================
- Coverage 77.80% 77.78% -0.02%
===========================================
Files 713 714 +1
Lines 54994 55162 +168
===========================================
+ Hits 42786 42906 +120
- Misses 12208 12256 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
valere/e2ee_message_shields
branch
from
9d67e4f to
93c1330
Compare
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds warnings to the timeline items in encrypted rooms when the authenticity can't be validated. It is behind a feature flag and doesn't surface the error message, only an icon. The icons are subject to change.
Original
Adds message shields (lax mode) Depends on SDK change https://github.com/matrix-org/matrix-rust-sdk/pull/3679Design: https://www.figma.com/design/2aqj9A5WRvGY3tcdTrBek4/Unencrypted-message-warning-in-Timeline?node-id=910-77038&t=pF5GGduo3EsrFG2Q-0
Note for reviewer / Open questions
I need to add a new Icon to the Compound Icons (plain shield OFF mode - strike through)