Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a feature flag for Message Pinning. #3063

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Add a feature flag for Message Pinning. #3063

merged 3 commits into from
Jul 18, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 18, 2024 •
edited
Loading

this also includes swiftlint error on line_legth removal alongside increasing the warning value from 1000 to 2000
Simulator Screenshot - iPhone 15 - 2024-07-18 at 15 27 25

@Velin92 Velin92 requested a review from a team as a code owner July 18, 2024 13:59
@Velin92 Velin92 requested review from stefanceriu and removed request for a team July 18, 2024 13:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4605293

@Velin92 Velin92 added the pr-feature for a new feature label Jul 18, 2024
stefanceriu
stefanceriu approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but are you sure you want to put Pinning items Feature Flag as a feature in the changelog?

@pixlwave
Copy link
Member

in the changelog?

Also (drive-by comment here) would be nice to use pr-wip as the category for things most people won't see.

@Velin92 Velin92 added pr-wip for anything that isn't ready to ship and will be enabled at a later date and removed pr-feature for a new feature labels Jul 18, 2024
@Velin92 Velin92 force-pushed the mauroromito/message_pinning_ff branch from ea56238 to 84a7b28 Compare July 18, 2024 15:27
@Velin92 Velin92 enabled auto-merge (squash) July 18, 2024 15:29
@Velin92 Velin92 disabled auto-merge July 18, 2024 16:28
@Velin92 Velin92 merged commit d437e1f into develop Jul 18, 2024
3 of 4 checks passed
@Velin92 Velin92 deleted the mauroromito/message_pinning_ff branch July 18, 2024 16:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave changed the title Pinning items Feature Flag Add a feature flag for Message Pinning. Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velin92 @pixlwave @stefanceriu