Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a certificate validator hook. #3069

Merged
merged 4 commits into from
Jul 19, 2024

Don't worry about the generic call links.

d00f05e
Select commit
Loading
Failed to load commit list.
Merged

Add a certificate validator hook. #3069

Don't worry about the generic call links.
d00f05e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 19, 2024 in 0s

77.83% (-0.11%) compared to 74907d3

View this Pull Request on Codecov

77.83% (-0.11%) compared to 74907d3

Details

Codecov Report

Attention: Patch coverage is 19.04762% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (74907d3) to head (d00f05e).

Files Patch % Lines
ElementX/Sources/AppHooks/AppHooks.swift 23.52% 13 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 6 Missing ⚠️
...rces/AppHooks/Hooks/CertificateValidatorHook.swift 0.00% 3 Missing ⚠️
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 3 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 2 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 33.33% 2 Missing ⚠️
...ces/Screens/CallScreen/CallScreenCoordinator.swift 0.00% 2 Missing ⚠️
...mentX/Sources/AppHooks/Hooks/AppSettingsHook.swift 0.00% 1 Missing ⚠️
...ntX/Sources/AppHooks/Hooks/ClientBuilderHook.swift 0.00% 1 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3069      +/-   ##
===========================================
- Coverage    77.93%   77.83%   -0.11%     
===========================================
  Files          697      702       +5     
  Lines        54174    54208      +34     
===========================================
- Hits         42222    42193      -29     
- Misses       11952    12015      +63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov