Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editing items not in the timeline failing #3075

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix editing items not in the timeline failing #3075

merged 2 commits into from
Jul 22, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 22, 2024

Requires an SDK release.

@Velin92 Velin92 requested a review from a team as a code owner July 22, 2024 09:55
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 22, 2024 09:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 2393b1d

pixlwave
pixlwave approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (cdd763e) to head (af06760).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ne/TimelineController/RoomTimelineController.swift 0.00% 31 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3075      +/-   ##
===========================================
- Coverage    78.00%   77.97%   -0.04%     
===========================================
  Files          701      701              
  Lines        54186    54209      +23     
===========================================
  Hits         42270    42270              
- Misses       11916    11939      +23
Flag Coverage Δ
unittests 68.52% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 added the pr-bugfix for bug fix label Jul 22, 2024
@Velin92 Velin92 enabled auto-merge (squash) July 22, 2024 10:48
@Velin92 Velin92 force-pushed the mauroromito/restore_editing_by_id branch from af06760 to 2393b1d Compare July 22, 2024 11:15
@Velin92 Velin92 disabled auto-merge July 22, 2024 11:15
@Velin92 Velin92 changed the title Fix editing items not in the timeline failing Fix editing items not in the timeline failing Jul 22, 2024
@Velin92 Velin92 merged commit ff33c07 into develop Jul 22, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/restore_editing_by_id branch July 22, 2024 11:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-bugfix for bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave