Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the restoration of a Simplified Sliding Sync session. #3081

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

pixlwave
Copy link
Member

This fixes the following bugs:

  • Force closing the app signs you out.
  • Clearing the cache in Developer Options signs you out.
  • Missing verification/restoration prompts.

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jul 24, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 24, 2024 09:31
@pixlwave pixlwave requested review from stefanceriu and removed request for a team July 24, 2024 09:31
@pixlwave pixlwave changed the title Fix the restoration of a SSS session. Fix the restoration of a Simplified Sliding Sync session. Jul 24, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 76bad17

Copy link

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (bf22250) to head (76bad17).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    78.01%   78.02%           
========================================
  Files          703      703           
  Lines        54362    54384   +22     
========================================
+ Hits         42410    42432   +22     
  Misses       11952    11952           
Flag Coverage Δ
unittests 68.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 013240e into develop Jul 24, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/sss-restoration branch July 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants