Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File messages on timeline #311

Merged
merged 19 commits into from
Nov 16, 2022
Merged

File messages on timeline #311

merged 19 commits into from
Nov 16, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Nov 11, 2022

Fixes #310

Requires matrix-org/matrix-rust-sdk#1203

Timeline Preview
Simulator Screen Shot - iPhone 14 Pro - 2022-11-16 at 12 16 39 Simulator Screen Shot - iPhone 14 Pro - 2022-11-16 at 12 16 47

@github-actions
Copy link

github-actions bot commented Nov 11, 2022

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 83a2cba

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

Base automatically changed from ismail/238_video_playback to develop November 14, 2022 08:58
@ismailgulek ismailgulek enabled auto-merge (squash) November 15, 2022 15:09
@ismailgulek ismailgulek force-pushed the ismail/310_file_messages branch from e1b4ddc to e1624f8 Compare November 16, 2022 09:37
@ismailgulek ismailgulek disabled auto-merge November 16, 2022 11:08
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 34.91% // Head: 34.25% // Decreases project coverage by -0.66% ⚠️

Coverage data is based on head (0ffea83) compared to base (ce6b004).
Patch coverage: 8.19% of modified lines in pull request are covered.

❗ Current head 0ffea83 differs from pull request most recent head 83a2cba. Consider uploading reports for the commit 83a2cba to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    34.91%   34.25%   -0.67%     
===========================================
  Files          226      234       +8     
  Lines        15259    15609     +350     
  Branches      8026     8213     +187     
===========================================
+ Hits          5328     5347      +19     
- Misses        9803    10125     +322     
- Partials       128      137       +9     
Flag Coverage Δ
unittests 11.80% <6.57%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 0.00% <0.00%> (ø)
...s/Screens/FilePreview/FilePreviewCoordinator.swift 0.00% <0.00%> (ø)
...s/Screens/FilePreview/View/FilePreviewScreen.swift 0.00% <0.00%> (ø)
...s/Screens/MediaPlayer/MediaPlayerCoordinator.swift 0.00% <0.00%> (ø)
...s/Screens/MediaPlayer/View/MediaPlayerScreen.swift 0.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 62.50% <ø> (-37.50%) ⬇️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 36.31% <0.00%> (-1.51%) ⬇️
...oomScreen/View/Timeline/FileRoomTimelineView.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...ces/Services/Timeline/RoomTimelineController.swift 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek enabled auto-merge (squash) November 16, 2022 11:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit 287fa4c into develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File message support
2 participants