Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a memory leak #3143

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix for a memory leak #3143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffcbc71
fix memory leak
Velin92 Aug 8, 2024
f5d99d9
commenting code
Velin92 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,16 +440,14 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
.store(in: &cancellables)

Task { [weak self] in
guard let self else {
return
}
// Don't guard let self here, otherwise the for await will strongify the self reference creating a strong reference cycle.
// If the subscription has sent a value before the Task has started it might be lost, so before entering the loop we always do an update.
await updatePinnedEventIDs()
await self?.updatePinnedEventIDs()
for await _ in roomInfoSubscription.receive(on: DispatchQueue.main).values {
guard !Task.isCancelled else {
return
}
await updatePinnedEventIDs()
await self?.updatePinnedEventIDs()
}
}
.store(in: &cancellables)
Expand Down
Loading