-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoomScreenViewModel refactor part 2 #3169
Conversation
Generated by 🚫 Danger Swift against 7f5032b |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🧹✨
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3169 +/- ##
===========================================
+ Coverage 77.30% 77.63% +0.32%
===========================================
Files 716 717 +1
Lines 55976 56143 +167
===========================================
+ Hits 43272 43585 +313
+ Misses 12704 12558 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also added more tests and also fixes #2991