Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomScreenViewModel refactor part 2 #3169

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 14, 2024

Also added more tests and also fixes #2991

@Velin92 Velin92 requested a review from a team as a code owner August 14, 2024 15:37
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team August 14, 2024 15:37
Copy link

github-actions bot commented Aug 14, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7f5032b

@Velin92 Velin92 added the pr-bugfix for bug fix label Aug 14, 2024
@Velin92 Velin92 enabled auto-merge (squash) August 14, 2024 15:41
Copy link

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🧹✨

@Velin92 Velin92 merged commit 0bbdb05 into develop Aug 14, 2024
8 checks passed
@Velin92 Velin92 deleted the mauroromito/roomscreenviewmodel_refactor_2 branch August 14, 2024 16:03
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 82.29167% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.63%. Comparing base (c71da91) to head (7f5032b).
Report is 3 commits behind head on develop.

Files Patch % Lines
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 37.50% 5 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 85.71% 5 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 62.50% 3 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 33.33% 2 Missing ⚠️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 50.00% 1 Missing ⚠️
...ine/View/Style/TimelineItemBubbledStylerView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3169      +/-   ##
===========================================
+ Coverage    77.30%   77.63%   +0.32%     
===========================================
  Files          716      717       +1     
  Lines        55976    56143     +167     
===========================================
+ Hits         43272    43585     +313     
+ Misses       12704    12558     -146     
Flag Coverage Δ
unittests 68.42% <82.29%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power level changes don't get reflected immediately when in a room.
2 participants