Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show encryption authenticity warnings on messages in the timeline. #3180

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 19, 2024

Now that the feature is available on Android, we can remove the feature flag on iOS.

@pixlwave pixlwave requested a review from a team as a code owner August 19, 2024 08:29
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 19, 2024 08:29
@pixlwave pixlwave added the pr-feature for a new feature label Aug 19, 2024
@pixlwave pixlwave changed the title Remove encryption authenticity feature flag. Show message encryption authenticity warnings in the timeline. Aug 19, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 981e79f

Copy link

@pixlwave pixlwave merged commit 6616d17 into develop Aug 19, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/enable-encryption-warnings branch August 19, 2024 08:49
@pixlwave pixlwave changed the title Show message encryption authenticity warnings in the timeline. Show encryption authenticity warnings on messages in the timeline. Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.82%. Comparing base (ebf7c00) to head (981e79f).
Report is 2 commits behind head on develop.

Files Patch % Lines
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3180      +/-   ##
===========================================
- Coverage    77.86%   77.82%   -0.04%     
===========================================
  Files          716      716              
  Lines        56461    56448      -13     
===========================================
- Hits         43961    43931      -30     
- Misses       12500    12517      +17     
Flag Coverage Δ
unittests 68.35% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants