Pinned Events Timeline actions and differentiation

[Velin92]

fixes #3060

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-21.at.13.39.08.mp4

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d32babd

[codecov]

Codecov Report

Attention: Patch coverage is 53.60624% with 238 lines in your changes missing coverage. Please review.

Project coverage is 77.48%. Comparing base (d54e08e) to head (d32babd).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
...dinators/PinnedEventsTimelineFlowCoordinator.swift	0.00%	113 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift	27.94%	49 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift	0.00%	22 Missing ⚠️
...melineScreen/View/PinnedEventsTimelineScreen.swift	22.22%	14 Missing ⚠️
...imeline/View/ItemMenu/TimelineItemMenuAction.swift	10.00%	9 Missing ⚠️
...View/ItemMenu/TimelineItemMenuActionProvider.swift	0.00%	6 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift	75.00%	4 Missing ⚠️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift	94.64%	3 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift	0.00%	3 Missing ⚠️
.../Screens/Timeline/TimelineInteractionHandler.swift	0.00%	3 Missing ⚠️
... and 6 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3182      +/-   ##
===========================================
- Coverage    77.68%   77.48%   -0.20%     
===========================================
  Files          718      719       +1     
  Lines        56695    57032     +337     
===========================================
+ Hits         44041    44193     +152     
- Misses       12654    12839     +185     

Flag	Coverage Δ
unittests	68.23% <53.60%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pixlwave]

Veery nice 🤩

A thought whilst I was reading through this. I think the notion of isLive on a timeline is likely wrong now - we should probably be using an enum of case live, detached, pinned instead. I have a feeling this would mean we didn't need to inject a bunch of those shouldHideStart/isPinnedEventsTimeline parameters as they could read this from the TimelineProxy, TimelineProvider, TimelineController or TimelineTableViewController. Definitely not to fix in this PR though.

Also a couple of thoughts on naming I wasn't sure where to put:

• I don't really think changing focussedEvent → focusEvent is a good change. It doesn't read as clearly as presentRoom(focussedEvent: theEvent) to me.
• I find it slightly confusing that sometimes it's we say the pinEvent and other times we say the pinnedEvent. I would have thought we always refer to it as the latter and we only use pin event as a verb?

[sonarqubecloud]

Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud