-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native video call picture in picture! #3190
Conversation
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger Swift against dad9618 |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tpVBfA |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3190 +/- ##
===========================================
+ Coverage 77.71% 77.82% +0.11%
===========================================
Files 717 718 +1
Lines 56478 56655 +177
===========================================
+ Hits 43893 44093 +200
+ Misses 12585 12562 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ae1facc
to
833ba53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few suggestions/nits
|
This PR uses an
AVPictureInPictureVideoCallController
to PiP the whole EC web view instead of the previous solution where EC would request the web view to PiP the speaker's video. I've made the feature flag user configurable now as it no longer requires a specific EC deployment*.This PR doesn't handle responses from the web view about whether PiP is possible so it is possible to get stuck in a call when an error occurs.
The second and third commits improves the handling of whether or not the we should start the PiP or dismiss the screen.
The fourth commit hides the call button when you're already joined to the call in that room.
* It subsequently does now, however when using an unsupported deployment it will simply navigate back which isn't the case with the old implementation on
develop
. The user can enter https://pr2573--element-call.netlify.app/ as the base URL above the flag for testing purposes.