-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimelineKind
refactor
#3193
TimelineKind
refactor
#3193
Conversation
Generated by 🚫 Danger Swift against da224a6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this feels much clearer about what's going on and will scale much better if we add another type of timeline in the future. 🙌
02f0a4f
to
e66b16d
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3193 +/- ##
===========================================
- Coverage 77.21% 77.21% -0.01%
===========================================
Files 719 719
Lines 57044 57033 -11
===========================================
- Hits 44047 44036 -11
Misses 12997 12997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
isLive
has been replaced with aTimelineKind enum
to allow a better handling of the pinned timeline