Update the SDK #3196
Update the SDK #3196
Conversation
Generated by 🚫 Danger Swift against 3b01f1b |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3196 +/- ##
===========================================
- Coverage 77.46% 77.28% -0.18%
===========================================
Files 719 722 +3
Lines 57033 57223 +190
===========================================
+ Hits 44178 44224 +46
- Misses 12855 12999 +144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| case unknown | ||
| } | ||
|
|
||
| var isSendingFailed: Bool { |
There was a problem hiding this comment.
Want to rename this into hasSendingFailed so hard but I also get it 🎭
| if FileManager.default.directoryExists(at: sessionDirectories.dataDirectory) { | ||
| try? FileManager.default.removeItem(at: sessionDirectories.dataDirectory) | ||
| } | ||
| if FileManager.default.directoryExists(at: sessionDirectories.cacheDirectory) { | ||
| try? FileManager.default.removeItem(at: sessionDirectories.cacheDirectory) |
There was a problem hiding this comment.
SessionDirectories should maybe handle this on its own and be reused for the QRLoginService below.
| let dataDirectory = try container.decodeIfPresent(URL.self, forKey: .sessionDirectory) | ||
| let cacheDirectory = try container.decodeIfPresent(URL.self, forKey: .cacheDirectory) | ||
|
|
||
| let sessionDirectories = if let dataDirectory { |
There was a problem hiding this comment.
Continuing from the comment above I wonder if we can or should make the SessionDirectories create itself from a container 🤔
| @@ -158,22 +158,36 @@ class UserSessionStore: UserSessionStoreProtocol { | |||
| appSettings: appSettings) | |||
| } | |||
|
|
|||
| private func deleteSessionDirectory(for credentials: KeychainCredentials) { | |||
| private func deleteSessionDirectories(for credentials: KeychainCredentials) { | |||
There was a problem hiding this comment.
Same question here I guess: can we move and hide a bunch of this logic into the new SessionDirectories?
|
Discussed in a call that I'll do a follow-up PR that refactors this a bit more after we make the RC. We're happy with the serialisation of the |
This PR updates the SDK to the latest version which with it brings the following code changes:
EncryptionAuthenticitystate for users who were previously verified but have now reset their identity.appGroupContainer/Library/Caches/…using the newcachePathon the client builder and we're implementing this at the right time to not require a migration.And the following SDK changes for free:
This is definitely one to review commit-by-commit.
Fixes #3202