Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Sliding Sync Discovery #3211

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Native Sliding Sync Discovery #3211

merged 5 commits into from
Aug 30, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 29, 2024

This PR adopts the latest changes in the SDK for Sliding Sync discovery. Changes are as follows:

  • Restoration: This is fully handled through the Session, and we don't to use .simplified based on the FF any more.
  • Configuration: There is a new picker in the developer options to choose the SSS type
    • Proxy only is the current type of discovery
    • Automatic will attempt native discovery and fallback to proxy discovery if native SS isn't available.
    • Force Native will use native SS without any discovery. This is necessary for matrix.org as support isn't advertised without a token that's on the allowlist.
  • Authentication: Make a new AuthenticationClientBuilder that handles the above configurations appropriately.

Copy link

github-actions bot commented Aug 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e47e76c

@pixlwave pixlwave force-pushed the doug/sss-discovery branch from 420be7a to 0b22144 Compare August 29, 2024 13:42
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 29, 2024
@pixlwave pixlwave marked this pull request as ready for review August 29, 2024 13:49
@pixlwave pixlwave requested a review from a team as a code owner August 29, 2024 13:49
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 29, 2024 13:49
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 13.76147% with 94 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (b1af4af) to head (e47e76c).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...s/Authentication/AuthenticationClientBuilder.swift 0.00% 48 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 11 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 9 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 9 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 3 Missing ⚠️
...ionsScreen/DeveloperOptionsScreenCoordinator.swift 0.00% 3 Missing ⚠️
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% 3 Missing ⚠️
...ptionsScreen/DeveloperOptionsScreenViewModel.swift 0.00% 2 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 2 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3211      +/-   ##
===========================================
+ Coverage    77.14%   77.43%   +0.28%     
===========================================
  Files          722      723       +1     
  Lines        57220    57256      +36     
===========================================
+ Hits         44145    44337     +192     
+ Misses       13075    12919     -156     
Flag Coverage Δ
unittests 68.24% <13.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/sss-discovery branch from 82080f8 to e47e76c Compare August 30, 2024 11:20
Copy link

@stefanceriu stefanceriu merged commit 904045f into develop Aug 30, 2024
10 checks passed
@stefanceriu stefanceriu deleted the doug/sss-discovery branch August 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants