Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept current autocorrection/suggestion before sending a message #3219

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner September 2, 2024 10:02
@stefanceriu stefanceriu changed the title Accept current autocorrection/suggestion before sendinga message Accept current autocorrection/suggestion before sending a message Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 470d7ab

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I trust you about the temporary UITextField field ;)

@stefanceriu
Copy link
Member Author

stefanceriu commented Sep 2, 2024

Not particularly happy about it either but the only other solution I found was to resign+become firstResponder which was creating UI glitches.

Turns out there is a better way https://stackoverflow.com/a/27865136/730924

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (302df18) to head (470d7ab).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...mScreen/ComposerToolbar/View/ComposerToolbar.swift 7.69% 12 Missing ⚠️
...omposerToolbar/View/MessageComposerTextField.swift 56.52% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3219      +/-   ##
===========================================
- Coverage    77.59%   77.58%   -0.01%     
===========================================
  Files          723      723              
  Lines        57282    57315      +33     
===========================================
+ Hits         44446    44470      +24     
- Misses       12836    12845       +9     
Flag Coverage Δ
unittests 68.22% <42.10%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Sep 2, 2024

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 2, 2024
@stefanceriu stefanceriu merged commit 062811c into develop Sep 2, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/3216 branch September 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants