Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pinned events required state in SlidingSync #3225

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Sep 3, 2024

Look Ma, I'm an iOS dev now!

Changes

Make pinned events required state in SlidingSync. This is needed to always have the pinned events of a room as soon as we open it.

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@jmartinesp jmartinesp requested a review from a team as a code owner September 3, 2024 14:59
@jmartinesp jmartinesp requested review from stefanceriu and removed request for a team September 3, 2024 14:59
@jmartinesp jmartinesp added the pr-bugfix for bug fix label Sep 3, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice catch, thank you!

This is needed to always have the pinned events of a room as soon as we open it.
@stefanceriu stefanceriu force-pushed the fix/room-pinned-events-is-required-state branch from 77476bb to dd172e1 Compare September 3, 2024 15:14
@stefanceriu stefanceriu enabled auto-merge (rebase) September 3, 2024 15:15
@stefanceriu stefanceriu disabled auto-merge September 3, 2024 15:19
Copy link

sonarqubecloud bot commented Sep 3, 2024

@stefanceriu stefanceriu enabled auto-merge (rebase) September 3, 2024 15:19
@stefanceriu stefanceriu disabled auto-merge September 3, 2024 15:24
@stefanceriu stefanceriu merged commit 3b0f02d into element-hq:develop Sep 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants