crypto: Add configuration flag to enable invisible crypto

[BillCarsonFr]

Fixes #2932

Adds a configuration flag (via AppSettings to enabled invisible crypto mode). The setting is Off by default.
Also adds a toggle to the dev tool screen for testing:

Pull Request Checklist

• I read the contributing guide.
• Pull request contains a changelog label.
• Pull request includes a sign off.

UI changes have been tested with:

• iPhone and iPad simulators in portrait and landscape orientations.
• Dark mode enabled and disabled.
• Various sizes of dynamic type.
• Voiceover enabled.

[github-actions]

	Fails
🚫	danger-swift failed.

Log

/var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/286840A8-BB80-4B4A-8695-C3EB085F2460/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/286840A8-BB80-4B4A-8695-C3EB085F2460/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against 331ccbc

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
824	1	823	0

View the top 1 failed tests by shortest run time

PreviewTests test_joinRoomScreen()

Stack Traces | 18.2s run time

failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-15-pseudo.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-15-pseudo.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9593811 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:1021)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[pixlwave]

Heads up that I just merged #3215 which also calls roomKeyRecipientStrategy(strategy:) on the ClientBuilder. I don't think it should conflict with your PR given it is called earlier, but feel free to move it around to make it clearer if you want :)

[BillCarsonFr]

Heads up that I just merged #3215 which also calls roomKeyRecipientStrategy(strategy:) on the ClientBuilder. I don't think it should conflict with your PR given it is called earlier, but feel free to move it around to make it clearer if you want :)

Ok, I'll rebase. I will move your call to roomKeyRecipientStrategy around the same place to set it as default unless the lab flag is set

[BillCarsonFr]

Ok, I'll rebase. I will move your call to roomKeyRecipientStrategy around the same place to set it as default unless the lab flag is set

@pixlwave a1e5739

[pixlwave]

Nice, thanks 👍

[pixlwave]

Nice, its exciting to see invisible crypto being added.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud