Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test results to Codecov. #3266

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Upload test results to Codecov. #3266

merged 6 commits into from
Sep 12, 2024

Conversation

pixlwave
Copy link
Member

This PR (hopefully) uploads our test results to Codecov to try out their new Test analytics dashboard 🤞

https://app.codecov.io/gh/element-hq/element-x-ios/tests

Copy link

github-actions bot commented Sep 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4eb6264

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (0d9d8f9) to head (4eb6264).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3266      +/-   ##
===========================================
- Coverage    77.59%   77.44%   -0.16%     
===========================================
  Files          725      725              
  Lines        58734    58734              
===========================================
- Hits         45577    45484      -93     
- Misses       13157    13250      +93     
Flag Coverage Δ
unittests 68.99% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave marked this pull request as ready for review September 11, 2024 16:21
@pixlwave pixlwave requested a review from a team as a code owner September 11, 2024 16:21
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 11, 2024 16:21
@pixlwave
Copy link
Member Author

pixlwave commented Sep 11, 2024

This seems to work well enough to merge. UI and Integration tests are both included in the dashboard.

@pixlwave
Copy link
Member Author

I think the duplicates in the dashboard are due to my adding the flags after the first few runs…

Copy link

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veeery nice! 👌

@pixlwave pixlwave merged commit 022cc59 into develop Sep 12, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/codecov-tests branch September 12, 2024 06:09
@pixlwave pixlwave changed the title Try uploading test results to Codecov. Uploade test results to Codecov. Sep 12, 2024
@pixlwave pixlwave changed the title Uploade test results to Codecov. Upload test results to Codecov. Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants