Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we reset the feature flag when upgrading to SSS. #3272

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 12, 2024

Currently if you tap the banner to Logout & Upgrade, if you have changed the discovery to Proxy only, you will be logged back in using SS and not SSS and will be presented with the banner again.

Same for the alert I would imagine too.

@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 12, 2024
@pixlwave pixlwave requested a review from a team as a code owner September 12, 2024 08:47
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 12, 2024 08:47
Copy link

github-actions bot commented Sep 12, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against b6d0ec3

@pixlwave pixlwave force-pushed the doug/sss-migration-fix branch from d5d5751 to b6d0ec3 Compare September 12, 2024 08:52
Copy link

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@pixlwave pixlwave enabled auto-merge (squash) September 12, 2024 09:05
@pixlwave pixlwave disabled auto-merge September 12, 2024 09:12
@pixlwave pixlwave enabled auto-merge (squash) September 12, 2024 09:13
@pixlwave pixlwave disabled auto-merge September 12, 2024 09:25
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (022cc59) to head (b6d0ec3).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3272   +/-   ##
========================================
  Coverage    77.51%   77.51%           
========================================
  Files          725      725           
  Lines        58734    58736    +2     
========================================
+ Hits         45527    45529    +2     
  Misses       13207    13207           
Flag Coverage Δ
unittests 69.00% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit a1c47ad into develop Sep 12, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/sss-migration-fix branch September 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants