Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added analytics for message pinning #3284

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 16, 2024

Analytics for message pinning

@Velin92 Velin92 requested a review from a team as a code owner September 16, 2024 14:57
@Velin92 Velin92 requested review from stefanceriu and removed request for a team September 16, 2024 14:57
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Fails
🚫

danger-swift failed.

Log

/var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/E121D9B3-07C5-4AF1-B7CC-D282A7A34BF0/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/E121D9B3-07C5-4AF1-B7CC-D282A7A34BF0/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against 5043b77

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.34%. Comparing base (20f4a43) to head (5043b77).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../Screens/Timeline/TimelineInteractionHandler.swift 0.00% 5 Missing ⚠️
.../Sources/Services/Analytics/AnalyticsService.swift 0.00% 3 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift 0.00% 1 Missing ⚠️
...neScreen/PinnedEventsTimelineScreenViewModel.swift 66.66% 1 Missing ⚠️
...RoomDetailsScreen/RoomDetailsScreenViewModel.swift 0.00% 1 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3284      +/-   ##
===========================================
- Coverage    77.40%   77.34%   -0.06%     
===========================================
  Files          730      730              
  Lines        59109    59122      +13     
===========================================
- Hits         45751    45728      -23     
- Misses       13358    13394      +36     
Flag Coverage Δ
unittests 68.73% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 force-pushed the mauroromito/pinning_analytics branch from beeef85 to 5043b77 Compare September 17, 2024 08:02
@Velin92 Velin92 merged commit efe352c into develop Sep 17, 2024
3 of 4 checks passed
@Velin92 Velin92 deleted the mauroromito/pinning_analytics branch September 17, 2024 08:02
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants