Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new strings for send failures when the unsigned devices are your own. #3299

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pixlwave
Copy link
Member

iOS equivalent to element-hq/element-x-android#3485

Item Menu Resolve failure sheet
test_timelineItemMenu-iPhone-15-en-GB Own-Unsigned-Devices test_resolveVerifiedUserSendFailureScreen-iPhone-15-en-GB Own-Unsigned-Device

@pixlwave pixlwave requested a review from a team as a code owner September 18, 2024 09:21
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 18, 2024 09:21
Copy link

Fails
🚫

danger-swift failed.

Log

/var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/FC774D86-9D58-4AC2-904C-1143793EF20D/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/FC774D86-9D58-4AC2-904C-1143793EF20D/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against f2526da

Copy link

@pixlwave pixlwave merged commit 63a0a99 into develop Sep 18, 2024
4 of 7 checks passed
@pixlwave pixlwave deleted the doug/unsigned-device-strings branch September 18, 2024 09:48
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (5625e78) to head (f2526da).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3299      +/-   ##
===========================================
- Coverage    77.27%   77.26%   -0.01%     
===========================================
  Files          735      735              
  Lines        59433    59425       -8     
===========================================
- Hits         45924    45916       -8     
  Misses       13509    13509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants