Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: rename invisible crypto flag to deviceIsolationMode #3331

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Sep 25, 2024

Pull Request Checklist

Fixes #3322

Rename the config flag, and dev tool lab flag as per discussions.

image

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 25, 2024 15:09
@BillCarsonFr BillCarsonFr requested review from stefanceriu and removed request for a team September 25, 2024 15:09
Copy link

github-actions bot commented Sep 25, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 94358c9

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.28%. Comparing base (dc6d7f2) to head (94358c9).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 3 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 2 Missing ⚠️
...s/Authentication/AuthenticationClientBuilder.swift 0.00% 1 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 1 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3331      +/-   ##
===========================================
- Coverage    77.31%   77.28%   -0.04%     
===========================================
  Files          740      740              
  Lines        59751    59751              
===========================================
- Hits         46196    46178      -18     
- Misses       13555    13573      +18     
Flag Coverage Δ
unittests 68.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr added the pr-bugfix for bug fix label Sep 25, 2024
@stefanceriu stefanceriu added pr-misc for other changes and removed pr-bugfix for bug fix labels Sep 26, 2024
@BillCarsonFr BillCarsonFr force-pushed the valere/rename_crypto_mode_in_labs branch from 4d9bb81 to 94358c9 Compare September 26, 2024 09:42
Copy link

@pixlwave pixlwave merged commit 23ab453 into develop Sep 26, 2024
10 of 11 checks passed
@pixlwave pixlwave deleted the valere/rename_crypto_mode_in_labs branch September 26, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes T-Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto: Rename Invisible Crypto lab flag
3 participants