Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the room header takes up as much space as possible (to hide the back button). #3335

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

pixlwave
Copy link
Member

Fixes #3289

toolbar.mov

@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 26, 2024
@pixlwave pixlwave requested a review from a team as a code owner September 26, 2024 14:15
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 26, 2024 14:15
Copy link

github-actions bot commented Sep 26, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1d31ef3

Copy link

codecov bot commented Sep 26, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
831 2 829 0
View the top 1 failed tests by shortest run time
RoomChangePermissionsScreenViewModelTests testSave()
Stack Traces | 2.05s run time
XCTAssertTrue failed (.../UnitTests/Sources/RoomChangePermissionsScreenViewModelTests.swift:64)
View the full list of 1 ❄️ flaky tests
PreviewTests test_timelineItemBubbledStylerView()

Flake rate in main: 33.33% (Passed 44 times, Failed 22 times)

Stack Traces | 17s run time
failed - Snapshot "Pinned messages" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineItemBubbledStylerView-iPhone-16-pseudo.Pinned-messages.png"
@+
"file:.../tmp/PreviewTests/test_timelineItemBubbledStylerView-iPhone-16-pseudo.Pinned-messages.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8688965 is less than required 1.0
The lowest perceptual color precision 0.18624997 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov.yml Show resolved Hide resolved
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey, ship it!

Copy link

@pixlwave pixlwave merged commit 2184081 into develop Sep 26, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/ios-18-toolbar branch September 26, 2024 17:07
@pixlwave pixlwave mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title jumps to the left slightly when entering a room (ios18)
2 participants