Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ElementCall always default to the speaker; prevent the lock button from ending the call #3338

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Have ElementCall always default to the speaker; prevent the lock button from ending the call #3338

merged 1 commit into from
Sep 27, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu
Have ElementCall always default to the speaker; prevent the lock butt…
e8bbe40 
…on from ending the call

- previously handled in 7818fa6
- seems the default behavior changed and we now need to manually configure the AudioSession
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 27, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 27, 2024 07:04
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 27, 2024 07:04
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e8bbe40

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fkwp fkwp mentioned this pull request Sep 27, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.30%. Comparing base (3b8da1c) to head (e8bbe40).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rces/Services/ElementCall/ElementCallService.swift 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3338      +/-   ##
===========================================
- Coverage    77.38%   77.30%   -0.09%     
===========================================
  Files          740      740              
  Lines        59723    59734      +11     
===========================================
- Hits         46215    46175      -40     
- Misses       13508    13559      +51
Flag Coverage Δ
unittests 68.52% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 4080ff1 into develop Sep 27, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/elementCallLockButton branch September 27, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-bugfix for bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave