Selecting a server that doesn't support login now fails instead of letting you continue to a failure later.

[pixlwave]

This matches the behaviour for registration introduced by #3316.

Additionally re-works ServerSelectionScreen to have all the logic in the view model to follow our normal architecture.

Before

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-09-25.at.10.38.16.mp4

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-09-27.at.13.11.47.mp4

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1d6a71f

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[stefanceriu]

Very nice! lgtm 👍

[codecov]

Codecov Report

Attention: Patch coverage is 96.31336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (df6d0a9) to head (1d6a71f).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ctionScreen/ServerSelectionScreenCoordinator.swift	0.00%	7 Missing ⚠️
...lectionScreen/ServerSelectionScreenViewModel.swift	98.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3342      +/-   ##
===========================================
+ Coverage    77.32%   77.35%   +0.03%     
===========================================
  Files          740      740              
  Lines        59746    59942     +196     
===========================================
+ Hits         46199    46369     +170     
- Misses       13547    13573      +26     

Flag	Coverage Δ
unittests	68.76% <96.31%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.