Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto correction when running on the Mac #3364

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Oct 3, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 3, 2024 10:32
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team October 3, 2024 10:32
Copy link

github-actions bot commented Oct 3, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 6f814d3

Copy link

sonarqubecloud bot commented Oct 3, 2024

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanceriu stefanceriu merged commit 4f29821 into develop Oct 3, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/autocorrectionOnTheMac branch October 3, 2024 10:49
Copy link

codecov bot commented Oct 3, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
838 1 837 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 38.18% (Passed 34 times, Failed 21 times)

Stack Traces | 2.25s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants