-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a warning when a user's pinned identity changes #3368
Conversation
1022f36
to
e70c1d1
Compare
Generated by 🚫 Danger Swift against fb21b17 |
e70c1d1
to
07ac99b
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3368 +/- ##
===========================================
+ Coverage 77.21% 77.56% +0.34%
===========================================
Files 739 740 +1
Lines 59962 60193 +231
===========================================
+ Hits 46302 46689 +387
+ Misses 13660 13504 -156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there is one thing that needs to be changed
07ac99b
to
7a7c7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
036a95c
to
91562db
Compare
…user's pinned identity changes
91562db
to
fb21b17
Compare
Quality Gate passedIssues Measures |
As per element-hq/element-meta#2544
Using matrix-org/matrix-rust-sdk#4022 and matrix-org/matrix-rust-sdk#4068
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-04.at.13.11.52.mp4