Image viewer #338

ismailgulek · 2022-11-24T13:17:48Z

Fixes #244

Also adds isModallyPresented functionality into the video player screen.

github-actions · 2022-11-24T13:19:13Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️	You seem to have made changes to views. Please consider adding screenshots.
⚠️	ElementX/Sources/Services/Timeline/RoomTimelineController.swift#L111 - Function should have complexity 10 or less: currently complexity equals 11 (`cyclomatic_complexity`)

Generated by 🚫 Danger Swift against a7f62f3

codecov · 2022-11-24T13:42:05Z

Codecov Report

Base: 33.83% // Head: 13.65% // Decreases project coverage by -20.17% ⚠️

Coverage data is based on head (f0f4e88) compared to base (9589c68).
Patch coverage: 3.61% of modified lines in pull request are covered.

❗ Current head f0f4e88 differs from pull request most recent head a7f62f3. Consider uploading reports for the commit a7f62f3 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #338       +/-   ##
============================================
- Coverage    33.83%   13.65%   -20.18%     
============================================
  Files          234      232        -2     
  Lines        15548    15149      -399     
  Branches      9229     7424     -1805     
============================================
- Hits          5260     2068     -3192     
- Misses       10130    13025     +2895     
+ Partials       158       56      -102

Flag	Coverage Δ
uitests	`?`
unittests	`13.65% <3.61%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/Screens/ImageViewer/ImageViewerCoordinator.swift	`0.00% <0.00%> (ø)`
...s/Screens/ImageViewer/View/ImageViewerScreen.swift	`0.00% <0.00%> (ø)`
...tX/Sources/Screens/Other/ActivityCoordinator.swift	`0.00% <0.00%> (ø)`
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift	`0.00% <0.00%> (-32.61%)`	⬇️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift	`0.00% <ø> (-100.00%)`	⬇️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift	`0.00% <0.00%> (-37.63%)`	⬇️
...s/Screens/VideoPlayer/VideoPlayerCoordinator.swift	`0.00% <0.00%> (ø)`
...s/Screens/VideoPlayer/View/VideoPlayerScreen.swift	`0.00% <0.00%> (ø)`
...ces/Services/Timeline/RoomTimelineController.swift	`0.00% <0.00%> (ø)`
...mentX/Sources/UITests/UITestScreenIdentifier.swift	`0.00% <ø> (-100.00%)`	⬇️
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stefanceriu

This looks great, albeit there are improvements we can make.

Another option would be to treat is similarly to files and use the QLPreviewController to display it, which would bring us a lot of features for free

Simulator.Screen.Recording.-.iPhone.14.-.2022-11-28.at.10.15.23.mp4