Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a subtitle to the QR Code login instructions. #3386

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 9, 2024

Fixes #3385.

test_qRCodeLoginScreen-iPhone-16-en-GB Initial

@pixlwave pixlwave requested a review from a team as a code owner October 9, 2024 10:21
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 9, 2024 10:21
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0a04f0b

Copy link

sonarqubecloud bot commented Oct 9, 2024

@pixlwave pixlwave changed the title Add a subtitle to the QR login instructions. Add a subtitle to the QR Code login instructions. Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
840 4 836 0
View the full list of 3 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 15.87% (Passed 228 times, Failed 43 times)

Stack Traces | 3.02s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.85461426 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_userProfileScreen()

Flake rate in main: 15.38% (Passed 198 times, Failed 36 times)

Stack Traces | 4.62s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9088135 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_joinRoomScreen()

Flake rate in main: 16.52% (Passed 192 times, Failed 38 times)

Stack Traces | 5.18s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9661255 is less than required 1.0
The lowest perceptual color precision 0.39999998 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 2194908 into develop Oct 9, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/qr-copy-update branch October 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Show a hint that QR code login is only available when the account provider supports it
2 participants