Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a feature flag for the new identity pinning violation notifications feature #3394

Merged

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-feature for a new feature label Oct 10, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 10, 2024 12:05
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team October 10, 2024 12:05
Copy link

github-actions bot commented Oct 10, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 442fac1

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@stefanceriu stefanceriu force-pushed the stefan/identityPinningViolationNotificationFeatureFlag branch from 979f25e to 9978a35 Compare October 10, 2024 12:30
@stefanceriu stefanceriu force-pushed the stefan/identityPinningViolationNotificationFeatureFlag branch from 9978a35 to 442fac1 Compare October 10, 2024 12:33
@stefanceriu stefanceriu enabled auto-merge (rebase) October 10, 2024 12:33
Copy link

@stefanceriu stefanceriu merged commit 4d697a3 into develop Oct 10, 2024
7 checks passed
@stefanceriu stefanceriu deleted the stefan/identityPinningViolationNotificationFeatureFlag branch October 10, 2024 13:13
Copy link

codecov bot commented Oct 10, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
840 2 838 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.40% (Passed 260 times, Failed 51 times)

Stack Traces | 2.38s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8474121 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_joinRoomScreen()

Flake rate in main: 17.34% (Passed 224 times, Failed 47 times)

Stack Traces | 10.8s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9661255 is less than required 1.0
The lowest perceptual color precision 0.39999998 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants