-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix identity pinning link. #3395
Conversation
Generated by 🚫 Danger Swift against b2b9d4d |
Quality Gate passedIssues Measures |
@@ -126,7 +126,7 @@ final class AppSettings { | |||
/// A URL where users can go read more about the chat backup. | |||
let chatBackupDetailsURL: URL = "https://element.io/help#encryption5" | |||
/// A URL where users can go read more about identity pinning violations | |||
let identityPinningViolationDetailsURL: URL = "https://element.io/help#18" | |||
let identityPinningViolationDetailsURL: URL = "https://element.io/help#encryption18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked on Android we're good.
❌ 2 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Based on element-hq/element-meta#2544 the link is missing part of the fragment.