Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous media request upload handle cancellation call. #3425

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Oct 16, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 16, 2024 16:56
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team October 16, 2024 16:56
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 0c03f8c

Copy link

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (0651314) to head (0c03f8c).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3425      +/-   ##
===========================================
- Coverage    77.75%   77.75%   -0.01%     
===========================================
  Files          738      738              
  Lines        60497    60496       -1     
===========================================
- Hits         47042    47037       -5     
- Misses       13455    13459       +4     
Flag Coverage Δ
unittests 69.27% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 6265217 into develop Oct 17, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/mediaCancellation branch October 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants