-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a UITableView component for the timeline. #349
Conversation
Generated by 🚫 Danger Swift against 2469f89 |
Codecov ReportBase: 34.41% // Head: 33.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #349 +/- ##
===========================================
- Coverage 34.41% 33.36% -1.05%
===========================================
Files 232 233 +1
Lines 15059 15537 +478
Branches 9188 9424 +236
===========================================
+ Hits 5182 5184 +2
- Misses 9728 10198 +470
- Partials 149 155 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bbd806b
to
4b98c21
Compare
4b98c21
to
81d98c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so promising, hope we can squash all the little edge cases and get something really solid out of it 👏
ElementX/Sources/Screens/RoomScreen/View/TimelineTableView.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 👏
This PR replaces the SwiftUI timeline with one based upon
UITableView
. The cells are configured with aUIHostingConfiguration
so are still SwiftUI based. This gives us the ability to update the scroll position after changing items but before the changes are rendered meaning the scroll jumps should be fixed.Hashable
for use in the diffable data source.TimelineView
has been merged intoRoomScreen
(happy to revert this if it doesn't make sense).Todo
ProgressView
to match the figma (future PR).Back.pagination.mp4