Hide the unread dot after previewing an invite. #3800
Conversation
| @@ -413,6 +426,7 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol | |||
| analyticsService.trackJoinedRoom(isDM: roomProxy.info.isDirect, | |||
| isSpace: roomProxy.info.isSpace, | |||
| activeMemberCount: UInt(roomProxy.info.activeMembersCount)) | |||
| appSettings.seenInvites.remove(roomID) | |||
There was a problem hiding this comment.
Honestly, I'm not really sure if this commit is necessary. We didn't do it before and joining from another client won't trigger this path. But it is nice to be able to leave a room and see a new invite as unread so I left it in 🤷♂️
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3800 +/- ##
===========================================
- Coverage 78.69% 78.66% -0.04%
===========================================
Files 793 794 +1
Lines 69341 70153 +812
===========================================
+ Hits 54570 55184 +614
- Misses 14771 14969 +198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/invite-badge
branch
from
5a67d87 to
9334d15
Compare
Refactor KnockRequestType to JoinRequestType.
pixlwave
force-pushed
the
doug/invite-badge
branch
from
9334d15 to
b7cd030
Compare
|
This PR reintroduces the
seenInvitesapp setting removed as part of #2821.Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-17.at.16.41.41.mp4