Remove support for the sliding sync proxy. #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles changes that removed support for the sliding sync proxy.
pixlwave
requested review from
Velin92 and
stefanceriu
and removed request for
a team and
Velin92
pixlwave
commented
Feb 18, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -75,9 +75,11 @@ protocol ClientProxyProtocol: AnyObject, MediaLoaderProtocol { | |||
| var deviceID: String? { get } | |||
|
|
|||
| var homeserver: String { get } | |||
|
|
|||
|
|
|||
| // TODO: This is a temporary value, in the future we should throw a migration error | |||
There was a problem hiding this comment.
⚠️ TODOs should be resolved (This is a temporary value, in ...) (todo)
| let container = try decoder.container(keyedBy: MatrixRustSDK.Session.CodingKeys.self) | ||
| session = try Session(from: decoder) | ||
|
|
||
| // TODO: In the future we should decode this in the Session and throw a migration error if it contains a value. |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (In the future we should decode...) (todo)
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3801 +/- ##
==========================================
Coverage ? 78.68%
==========================================
Files ? 794
Lines ? 69483
Branches ? 0
==========================================
Hits ? 54674
Misses ? 14809
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stefanceriu
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK no longer supports a sliding sync proxy, so this update will force logout anyone using a sliding sync proxy:
migration.mp4