430 - Design review for first public TestFlight Part2 #496

gileluard · 2023-01-27T11:41:21Z

update for #430

Screen name	Light mode	Dark mode
Splash screen
User settings
Home Screen
verification flow

github-actions · 2023-01-27T11:42:37Z

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 8ff9122

codecov · 2023-01-27T12:00:53Z

Codecov Report

Base: 41.79% // Head: 41.55% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (8ff9122) compared to base (f29c0a9).
Patch coverage: 67.02% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #496      +/-   ##
===========================================
- Coverage    41.79%   41.55%   -0.25%     
===========================================
  Files          288      289       +1     
  Lines        15953    16079     +126     
  Branches     10317    10447     +130     
===========================================
+ Hits          6668     6682      +14     
- Misses        9018     9130     +112     
  Partials       267      267

Flag	Coverage Δ
unittests	`21.22% <6.27%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...it/Sources/Buttons/ElementCapsuleButtonStyle.swift	`0.00% <0.00%> (ø)`
...ources/Other/SwiftUI/Views/SettingsPickerRow.swift	`0.00% <0.00%> (ø)`
...s/Screens/Settings/SettingsScreenCoordinator.swift	`0.00% <0.00%> (ø)`
...ources/Screens/Settings/SettingsScreenModels.swift	`50.00% <ø> (-50.00%)`	⬇️
...ssion/UserSessionFlowCoordinatorStateMachine.swift	`38.70% <ø> (ø)`
...ces/Screens/Settings/SettingsScreenViewModel.swift	`71.42% <50.00%> (-15.24%)`	⬇️
...vices/UserSession/UserSessionFlowCoordinator.swift	`29.59% <50.00%> (ø)`
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	`48.98% <59.25%> (-0.50%)`	⬇️
...nVerification/View/SessionVerificationScreen.swift	`62.79% <80.00%> (-9.41%)`	⬇️
...essionVerification/SessionVerificationModels.swift	`53.70% <80.64%> (-42.97%)`	⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-01-30T10:25:39Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.