Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further design updates to the timeline. #524

Merged
merged 10 commits into from
Feb 3, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 3, 2023

  • Decryption banner on the timeline
  • Bubble colours
  • Background insets
  • Multiline composer corner radius
  • Read marker
  • GIF indicator
  • Reactions shape
  • Use RoomTimelineViewLabelStyle everywhere possible
  • Only set a line limit on reply quotes, allow all the lines for regular quotes.
  • Make icons consistent on timeline items that use Label
  • Yes/No button casing
  • Enable copy/invite buttons on room details.

Closes #430.

Encryption Banner / Read marker GIF indicator / Composer Dark Bubbles / Reply line limit State Events
Simulator Screen Shot - iPhone 14 - 2023-02-03 at 13 05 38 Simulator Screen Shot - iPhone 14 - 2023-02-03 at 13 07 14 Simulator Screen Shot - iPhone 14 - 2023-02-03 at 13 09 36 Simulator Screen Shot - iPhone 14 - 2023-02-03 at 13 10 01
Fixed Context menu
Simulator Screen Recording - iPhone 14 - 2023-02-03 at 13 12 04

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️

ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift#L39 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines (function_body_length)

Generated by 🚫 Danger Swift against 0b3d5bb

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 40.87% // Head: 40.66% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (0bfbf79) compared to base (183cc88).
Patch coverage: 21.37% of modified lines in pull request are covered.

❗ Current head 0bfbf79 differs from pull request most recent head 0b3d5bb. Consider uploading reports for the commit 0b3d5bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #524      +/-   ##
===========================================
- Coverage    40.87%   40.66%   -0.21%     
===========================================
  Files          289      290       +1     
  Lines        16662    16799     +137     
  Branches     11054    11201     +147     
===========================================
+ Hits          6810     6831      +21     
- Misses        9533     9636     +103     
- Partials       319      332      +13     
Flag Coverage Δ
unittests 20.81% <3.83%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/Other/SwiftUI/Views/SettingsActionButton.swift 0.00% <0.00%> (ø)
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 60.85% <0.00%> (ø)
...ources/Screens/RoomDetails/RoomDetailsModels.swift 0.00% <ø> (ø)
...ces/Screens/RoomDetails/RoomDetailsViewModel.swift 0.00% <0.00%> (ø)
...s/Screens/RoomDetails/View/RoomDetailsScreen.swift 0.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 26.92% <0.00%> (-1.08%) ⬇️
...reen/View/Timeline/EncryptedRoomTimelineView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)
...mScreen/View/Timeline/NoticeRoomTimelineView.swift 0.00% <0.00%> (ø)
...een/View/Timeline/ReadMarkerRoomTimelineView.swift 0.00% <0.00%> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- Decryption banner on the timeline
- Bubble colours
- Background insets
- Multiline composer corner radius
- Read marker
- GIF indicator
- Reactions shape
- Use RoomTimelineViewLabelStyle everywhere possible
- Only set a line limit on reply quotes, allow all the lines for regular quotes.
- Message label icons
- Yes/No button casing
@pixlwave pixlwave force-pushed the doug/timeline-mk-ii branch from c300a31 to 10a680c Compare February 3, 2023 11:45
@pixlwave pixlwave force-pushed the doug/timeline-mk-ii branch from 073e035 to ec4de39 Compare February 3, 2023 13:13
@pixlwave pixlwave marked this pull request as ready for review February 3, 2023 13:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amshakal
Copy link

amshakal commented Feb 3, 2023

😍😍😍

@pixlwave pixlwave merged commit 2aaeb57 into develop Feb 3, 2023
@pixlwave pixlwave deleted the doug/timeline-mk-ii branch February 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design review for first public TestFlight
3 participants