-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow blockquote bubbles to fill the message bubble #527
Conversation
Use a custom layout to prevent them from unnecessarily widening the bubble.
Generated by 🚫 Danger Swift against be83a58 |
Codecov ReportBase: 40.78% // Head: 40.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #527 +/- ##
===========================================
- Coverage 40.78% 40.54% -0.24%
===========================================
Files 290 290
Lines 16749 16847 +98
Branches 11166 11200 +34
===========================================
Hits 6831 6831
- Misses 9601 9700 +99
+ Partials 317 316 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline but also talked about this offline, looks good to me 👍
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Use a custom layout to prevent them from unnecessarily widening the bubble.
I hope the code is well enough documented to describe how this is done, please add comments where unclear and I'll add more documentation.