Fix navigationStackCoordinator getting torn down when being reset on … #613
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the navigationSplitCoordinator, added unit tests for it
Generated by 🚫 Danger Swift against d881665 |
stefanceriu
force-pushed
the
stefan/splitLayoutNavigationFix
branch
from
739be5a to
a7f87e8
Compare
|
More of a question: why we can't just compare the references of the two coordinators by using the |
That's a very very good idea 👏 I'm going to give it a shot |
|
Kudos, SonarCloud Quality Gate passed!
|
pixlwave
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the navigationSplitCoordinator, added unit tests for it
Navigating to rooms in split mode is currently broken. This happens because we set the
detailNavigationStackCoordinatormultiple times as thesplitCoordinator's detail. This in turn make thesplitCoordinatortear down its previous detail which just happens to be the same as the current one. As the detail is anavigationStackthat makes it reset itself and release all coordinatorsAs Coordinators are not currently equatable there's no good way to prevent this on the navigation coordinators level so instead we check against resetting that detail multiple times to the same instance