Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #650

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Various fixes #650

merged 2 commits into from
Feb 28, 2023

Conversation

stefanceriu
Copy link
Member

This PR fixes 2 bugs:

  1. Incorrect stack and split coordinator teardowns leading to possible multiple stops for the same coordinator
  2. Crashes on the settings screen which was showing the "complete verification" button before the session verification controller proxy was ready

@stefanceriu stefanceriu requested a review from pixlwave February 28, 2023 13:21
@github-actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 970cf4a

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pixlwave
pixlwave approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit a0de1ef into develop Feb 28, 2023
@stefanceriu stefanceriu deleted the stefan/bugFixing branch February 28, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave