Notifications Enabled

[Velin92]

Enabled notifications with default static text.

Also implemented a way to get to the original user that sent the notification (which will be useful for multi account support)

WHAT IS MISSING:

• Permalink support
• A way to handle navigations where we set coordinators without animations

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3ba8b3e

[codecov]

Codecov Report

Patch coverage: 39.39% and project coverage change: -0.02 ⚠️

Comparison is base (2439431) 50.82% compared to head (638f2f8) 50.80%.

❗ Current head 638f2f8 differs from pull request most recent head 3ba8b3e. Consider uploading reports for the commit 3ba8b3e to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #760      +/-   ##
===========================================
- Coverage    50.82%   50.80%   -0.02%     
===========================================
  Files          292      292              
  Lines        16072    16010      -62     
  Branches      9762     9740      -22     
===========================================
- Hits          8168     8134      -34     
+ Misses        7664     7637      -27     
+ Partials       240      239       -1     

Flag	Coverage Δ
unittests	25.43% <39.39%> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ElementX/Sources/Application/AppSettings.swift	95.91% <ø> (ø)
ElementX/Sources/Other/Extensions/Bundle.swift	58.97% <0.00%> (-41.03%)	⬇️
...s/Screens/RoomDetails/View/RoomDetailsScreen.swift	41.50% <0.00%> (ø)
...omMemberDetails/View/RoomMemberDetailsScreen.swift	43.37% <0.00%> (-1.21%)	⬇️
...ces/Notification/Proxy/NotificationItemProxy.swift	0.00% <0.00%> (ø)
.../Notification/Proxy/NotificationServiceProxy.swift	0.00% <0.00%> (ø)
...ces/Notification/Manager/NotificationManager.swift	85.60% <77.77%> (-1.18%)	⬇️
...ources/Services/UserSession/RestorationToken.swift	100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[stefanceriu]

Looks good to me but I left some changes inline.

Also, today's merge commit should've been a rebase instead.

[Velin92]

Looks good to me but I left some changes inline.

Also, today's merge commit should've been a rebase instead.

@stefanceriu actually regarding this... I used the default github update branch option, but this always defaults to a merge, at this point could we just disable it, or there is a way to force it to be always a rebase?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[stefanceriu]

🚢 it!