Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invites list unread badges #819

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Invites list unread badges #819

merged 1 commit into from
Apr 21, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Apr 21, 2023

Fix #714

Result
demo

@alfogrillo alfogrillo requested a review from a team as a code owner April 21, 2023 09:08
@alfogrillo alfogrillo requested review from stefanceriu and removed request for a team April 21, 2023 09:08
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 425f038

@alfogrillo alfogrillo force-pushed the alfogrillo/refactor_setting_wrapper branch from 7269f31 to 3e2cb12 Compare April 21, 2023 09:17
@alfogrillo alfogrillo force-pushed the alfogrillo/invites_badges branch from da203ec to 2407983 Compare April 21, 2023 09:17
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 73.49% and project coverage change: +0.09 🎉

Comparison is base (6700d43) 49.98% compared to head (e138ded) 50.07%.

❗ Current head e138ded differs from pull request most recent head 425f038. Consider uploading reports for the commit 425f038 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #819      +/-   ##
===========================================
+ Coverage    49.98%   50.07%   +0.09%     
===========================================
  Files          322      323       +1     
  Lines        18023    18153     +130     
  Branches     10495    10557      +62     
===========================================
+ Hits          9008     9091      +83     
- Misses        8759     8805      +46     
- Partials       256      257       +1     
Flag Coverage Δ
unittests 25.26% <73.49%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 87.50% <ø> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 54.41% <0.00%> (ø)
...ementX/Sources/Screens/Invites/InvitesModels.swift 100.00% <ø> (ø)
...urces/Screens/Invites/View/InvitesScreenCell.swift 49.67% <0.00%> (-16.74%) ⬇️
.../Screens/RoomScreen/View/Style/TimelineStyle.swift 92.30% <ø> (ø)
...vices/UserSession/UserSessionFlowCoordinator.swift 37.71% <0.00%> (-0.14%) ⬇️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 62.99% <54.54%> (-0.83%) ⬇️
...ntX/Sources/Screens/Invites/InvitesViewModel.swift 66.14% <81.81%> (+0.54%) ⬆️
ElementX/Sources/Application/AppSettings.swift 96.07% <100.00%> (+0.07%) ⬆️
ElementX/Sources/Other/UserPreference.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

ElementX/Sources/Screens/Invites/InvitesViewModel.swift Outdated Show resolved Hide resolved
@alfogrillo alfogrillo force-pushed the alfogrillo/refactor_setting_wrapper branch from 3e2cb12 to 5efccc7 Compare April 21, 2023 10:33
@alfogrillo alfogrillo force-pushed the alfogrillo/invites_badges branch from e138ded to 63fb034 Compare April 21, 2023 10:37
Base automatically changed from alfogrillo/refactor_setting_wrapper to develop April 21, 2023 10:46
@alfogrillo alfogrillo force-pushed the alfogrillo/invites_badges branch from 63fb034 to 425f038 Compare April 21, 2023 10:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo enabled auto-merge (squash) April 21, 2023 10:59
@alfogrillo alfogrillo merged commit 078799c into develop Apr 21, 2023
@alfogrillo alfogrillo deleted the alfogrillo/invites_badges branch April 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invites badge behavior
2 participants